Skip to content

Minor reword to improve readability #7838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2017
Merged

Conversation

javiereguiluz
Copy link
Member

This fixes #7202.

@@ -370,7 +370,7 @@ on the requested URI::
echo '<html><body><h1>Page Not Found</h1></body></html>';
}

For organization, both controllers (formerly ``index.php`` and ``show.php``)
For organization, both controllers (formerly ``/index.php`` and ``/index.php/show``)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not consistent with the filename above.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that the article talks about the controllers related to the list_action() and show_action() functions. Given that this controllers don't have a name, or a function or anything to refer to, I prefer to mention the original URI of each controller (/index.php and /index.php/show) to avoid issues like the original bug report. Otherwise, how can we solve this? Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you, so the filename above should be changed accordingly, that's what I meant :).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but I don't follow you. This is what I'm trying to do:

controller-names

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems I got confused by this line https://github.com/symfony/symfony-docs/pull/7838/files#diff-9bc9c246d5d01be55bf80517de478b73R333, but I understand now it does not need to be changed 😅

@@ -370,7 +370,7 @@ on the requested URI::
echo '<html><body><h1>Page Not Found</h1></body></html>';
}

For organization, both controllers (formerly ``index.php`` and ``show.php``)
For organization, both controllers (formerly ``/index.php`` and ``/index.php/show``)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems I got confused by this line https://github.com/symfony/symfony-docs/pull/7838/files#diff-9bc9c246d5d01be55bf80517de478b73R333, but I understand now it does not need to be changed 😅

@xabbuh
Copy link
Member

xabbuh commented Apr 27, 2017

Thank you @javiereguiluz.

@xabbuh xabbuh merged commit 425c83f into symfony:2.7 Apr 27, 2017
xabbuh added a commit that referenced this pull request Apr 27, 2017
This PR was merged into the 2.7 branch.

Discussion
----------

Minor reword to improve readability

This fixes #7202.

Commits
-------

425c83f Minor reword to improve readability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants